Conversation
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
@jchung722 I've reviewed it and provided some specific feedback and updated the progress report Google Doc.
Overall very well done. I like the mouth background in the search bar, although I missed the search results at first.
Good work
| @@ -0,0 +1,71 @@ | |||
| Rails.application.routes.draw do | |||
|
|
|||
There was a problem hiding this comment.
There are some routes here you're not using. Don't leave them in here if you're not using them.
| @@ -0,0 +1,48 @@ | |||
| require 'httparty' | |||
|
|
|||
There was a problem hiding this comment.
Good encapsulation of the recipe concept into the Recipe class.
| @@ -0,0 +1,57 @@ | |||
| require 'test_helper' | |||
There was a problem hiding this comment.
Good work on testing the positive and negative cases using the API.
I might also add a test for what happens with an API request with no results. Like searching for "asdf"
| :match_requests_on => [:method, :uri, :body] # The http method, URI and body of a request all need to match | ||
| } | ||
|
|
||
| config.filter_sensitive_data("<APP_KEY>") do |
There was a problem hiding this comment.
Good work filtering out the App_Key and id.
2 participants
Hello @CheezItMan !
Here is my updated api-muncher; there isn't anything too fancy yet, but would like to add OAuth and filters one day...!